Refactor InstallServer function to integrate DepotDownloader better #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is mostly to help #660 by updating DepotDownloader to the latest version and reorganize the installation script. I couldn't recreate the issue on my own ARM64 machine so I'm not sure if this would solve it. I'm hoping it has something to do with this change in the latest version:
At this point, DepotDownloader is our only option for Apple CPUs (and probably other ARM64 processors) to download the server files. Refactoring the script to integrate it with steamcmd even if it's not explicitly enabled will probably be a net positive for the user experience.
Choices
-NumberOfWorkerThreadsServer=$(nproc --all)
while I'm at it as suggested in Orange Pi 5 Max Performance improvement #640 since it's a pretty small change for an entirely new PR.Test instructions
Checklist before requesting a review